Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Check valid name and file #5383

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

Samuelopez-ansys
Copy link
Member

Without this check, the extension manager could delete the content of directories by mistake

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.37%. Comparing base (9f0e163) to head (88bad97).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5383   +/-   ##
=======================================
  Coverage   84.37%   84.37%           
=======================================
  Files         140      140           
  Lines       58463    58463           
=======================================
+ Hits        49327    49331    +4     
+ Misses       9136     9132    -4     

@maxcapodi78 maxcapodi78 merged commit 73be523 into main Nov 6, 2024
41 checks passed
@maxcapodi78 maxcapodi78 deleted the fix/extension_manager_issue branch November 6, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants